Temporarily remove Operation class usage for 0.20#7840
Conversation
Removing Operation release notes
|
Properties inherited from |
mtreinish
added
priority: high
Changelog: None
| from .controlledgate import ControlledGate | ||
| from .instruction import Instruction | ||
| from .instructionset import InstructionSet | ||
| from .operation import Operation |
There was a problem hiding this comment.
Do you want to drop this here? This means we're not re-exporting the Operation class from the root qiskit.circuit. This will limit who has access to the class. I'm fine with that as we're saying for 0.20.0 we added the class but nothing uses it yet. Just wanted to make sure that was the intent
There was a problem hiding this comment.
Yes, Matthew, I think it's better this way before we re-add it in way that solves #7528
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
This LGTM, thanks for doing this. Is there something we still need to do here to remove the WIP, I personally don't see anything missing from it.
eliarbel
changed the title
|
Nothing else to do, I was waiting for the CI to finish (my lint + tests are still running locally, nice to see how fast those servers are :-) ). WIP removed |
Pull Request Test Coverage Report for Build 2064899040
💛 - Coveralls |
3 participants
This PR temporarily removes
Operationfrom being a base class for various circuit element types due to the performance degradation found in #7528 and given the fact that theOperationclass intent is still not utilized inQuantumCirctuit.appendSummary
Details and comments